> On April 4, 2016, 9:40 a.m., Michael Park wrote: > > src/examples/dynamic_reservation_framework.cpp, lines 350-364 > > <https://reviews.apache.org/r/37168/diff/15/?file=1309849#file1309849line350> > > > > We should be able to just use the ones in `src/tests/mesos.hpp`.
I'd like to de-couple example from Mesos internal code, e.g. `tests/mesos.hpp`. Ideally, the user can build example with installed Mesos binaries & headers. - Klaus ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review126769 ----------------------------------------------------------- On March 22, 2016, 11:44 a.m., Klaus Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37168/ > ----------------------------------------------------------- > > (Updated March 22, 2016, 11:44 a.m.) > > > Review request for mesos, Greg Mann, Joerg Schad, and Michael Park. > > > Bugs: MESOS-3063 > https://issues.apache.org/jira/browse/MESOS-3063 > > > Repository: mesos > > > Description > ------- > > Provide example for dynamic reservation features. > > > Diffs > ----- > > src/Makefile.am 9dd21b56af0500f7125b07bf535b45fe5c544aaf > src/examples/dynamic_reservation_framework.cpp PRE-CREATION > src/tests/dynamic_reservation_framework_test.sh PRE-CREATION > src/tests/examples_tests.cpp 6ddac17bb2ac0330bcc09eaab975ae70e84a7695 > > Diff: https://reviews.apache.org/r/37168/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Klaus Ma > >
