> On April 4, 2016, 9:40 a.m., Michael Park wrote: > > src/examples/dynamic_reservation_framework.cpp, lines 69-70 > > <https://reviews.apache.org/r/37168/diff/15/?file=1309849#file1309849line69> > > > > Initialize these in member init list. > > > > ```cpp > > : ... > > principal(_principal), > > reservationInfo(createReservationInfo(principal)), > > taskResources(TASK_RESOURCES(role, reservationInfo)) > > ```
`createReservationInfo` is also included in `test/mesos.hpp`, I'd like to avoid such dependency; so initialize it in constructor. I'd like to drop this comments, please feel free to re-open it if more comments :). - Klaus ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review126769 ----------------------------------------------------------- On April 5, 2016, 5:28 p.m., Klaus Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37168/ > ----------------------------------------------------------- > > (Updated April 5, 2016, 5:28 p.m.) > > > Review request for mesos, Greg Mann, Joerg Schad, and Michael Park. > > > Bugs: MESOS-3063 > https://issues.apache.org/jira/browse/MESOS-3063 > > > Repository: mesos > > > Description > ------- > > Provide example for dynamic reservation features. > > > Diffs > ----- > > src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 > src/examples/dynamic_reservation_framework.cpp PRE-CREATION > src/tests/dynamic_reservation_framework_test.sh PRE-CREATION > src/tests/examples_tests.cpp 6ddac17bb2ac0330bcc09eaab975ae70e84a7695 > > Diff: https://reviews.apache.org/r/37168/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Klaus Ma > >
