----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45440/#review127262 -----------------------------------------------------------
Patch looks great! Reviews applied: [45067, 45440] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On April 5, 2016, 10:33 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45440/ > ----------------------------------------------------------- > > (Updated April 5, 2016, 10:33 p.m.) > > > Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and > Vinod Kone. > > > Bugs: MESOS-5062 > https://issues.apache.org/jira/browse/MESOS-5062 > > > Repository: mesos > > > Description > ------- > > Adds metrics to gauge the health of the framework. This includes: > > * uptime_secs = How long the framework has been running. > * registered = If the framework is registered. > * offers_received = A counter used to determine if the framework is starved > or not. > * tasks_launched = Number of tasks launched. > * abnormal_terminations = Number of terminal status updates which were not > `TASK_FINISHED`. > > Also adds an endpoint `/framework/counters` which returns the list of metrics > which are "counters". > > > Diffs > ----- > > src/examples/long_lived_framework.cpp > ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0 > > Diff: https://reviews.apache.org/r/45440/diff/ > > > Testing > ------- > > make check > > Also deployed this version on a test cluster. See the previous review. > > > Thanks, > > Joseph Wu > >
