----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45440/#review127404 -----------------------------------------------------------
src/examples/long_lived_framework.cpp (line 92) <https://reviews.apache.org/r/45440/#comment190700> do a `process::wait()` here as well? src/examples/long_lived_framework.cpp (line 241) <https://reviews.apache.org/r/45440/#comment190709> Looking at the code below I think it makes more sense to make LongLivedScheduler an instance of process instead of making Metrics a process? That is consistent with how we did it elsewhere in the code base (e.g., Master and Slave). src/examples/long_lived_framework.cpp (line 244) <https://reviews.apache.org/r/45440/#comment190704> why is the process based call "framework" here? src/examples/long_lived_framework.cpp (line 272) <https://reviews.apache.org/r/45440/#comment190701> s/counter/metrics/ I'm assuming you might want to add gauge type metrics to this endpoint in the future? More importantly, I didn't understand why you need to add a special endpoint for these 2 counters. Why can't they just be part of the "/metrics/snapshot" endpoint like the other metrics? src/examples/long_lived_framework.cpp (line 274) <https://reviews.apache.org/r/45440/#comment190702> s/counter-type// src/examples/long_lived_framework.cpp (line 275) <https://reviews.apache.org/r/45440/#comment190703> Why does this return 202 instead of 200? Looks like it is returning a 200 below btw. src/examples/long_lived_framework.cpp (lines 298 - 313) <https://reviews.apache.org/r/45440/#comment190707> seems a bit weird that these are part of the metrics class. In Master and Slave, we made these gauges part of the Master and Slave class instead. src/examples/long_lived_framework.cpp (line 312) <https://reviews.apache.org/r/45440/#comment190708> shouldn't this be synchronized? ideally this would be just deferred to the scheduler process. - Vinod Kone On April 5, 2016, 10:33 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45440/ > ----------------------------------------------------------- > > (Updated April 5, 2016, 10:33 p.m.) > > > Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and > Vinod Kone. > > > Bugs: MESOS-5062 > https://issues.apache.org/jira/browse/MESOS-5062 > > > Repository: mesos > > > Description > ------- > > Adds metrics to gauge the health of the framework. This includes: > > * uptime_secs = How long the framework has been running. > * registered = If the framework is registered. > * offers_received = A counter used to determine if the framework is starved > or not. > * tasks_launched = Number of tasks launched. > * abnormal_terminations = Number of terminal status updates which were not > `TASK_FINISHED`. > > Also adds an endpoint `/framework/counters` which returns the list of metrics > which are "counters". > > > Diffs > ----- > > src/examples/long_lived_framework.cpp > ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0 > > Diff: https://reviews.apache.org/r/45440/diff/ > > > Testing > ------- > > make check > > Also deployed this version on a test cluster. See the previous review. > > > Thanks, > > Joseph Wu > >
