> On June 8, 2016, 5:32 a.m., Benjamin Mahler wrote: > > src/tests/values_tests.cpp, line 210 > > <https://reviews.apache.org/r/43561/diff/5/?file=1310343#file1310343line210> > > > > If I understand correctly, the following are currently accepted way to > > specify 1-4: > > > > `[[1-4]]` > > `[1-2]\n[3-4]` > > `[1-2],[3-4]` > > > > I'm ok with rejecting these in favor of the following canonical formats: > > > > `[1-2,3-4]` > > > > Although it doesn't have to be coalesced. However, we should notify the > > user mailing list that we're moving towards more strict parsing of ranges > > if you're going to change what we accept. > > > > Ideally, we could pull in a regex or parsing expression grammar library > > to more formally define our formats. The current parsing code is a mess.
Logged MESOS-5602 to trace "expression grammar library", https://issues.apache.org/jira/browse/MESOS-5602 And i'll send an email to dev@ and user@ list for this notification. - Klaus ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43561/#review136543 ----------------------------------------------------------- On June 11, 2016, 10:29 p.m., Klaus Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43561/ > ----------------------------------------------------------- > > (Updated June 11, 2016, 10:29 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Joris Van > Remoortere. > > > Bugs: MESOS-4627 > https://issues.apache.org/jira/browse/MESOS-4627 > > > Repository: mesos > > > Description > ------- > > Improve Ranges parsing to handle single values. > > > Diffs > ----- > > src/common/values.cpp 587cb68551d438621e215953e89818b623b7f71b > src/tests/values_tests.cpp 929861549e3155c33966896f817f9bf9e6d14354 > > Diff: https://reviews.apache.org/r/43561/diff/ > > > Testing > ------- > > make > make check GTEST_FILTER=~"*" > ./src/mesos-test > > > Thanks, > > Klaus Ma > >
