> On June 8, 2016, 5:32 a.m., Benjamin Mahler wrote: > > src/common/values.cpp, lines 654-657 > > <https://reviews.apache.org/r/43561/diff/5/?file=1310341#file1310341line654> > > > > Can you pull this cleanup into a separate patch? Note that you don't > > need the variable: > > > > ``` > > foreach (const string& token, sstrings::tokenize(temp, "{},\n")) { > > set->add_item(token); > > } > > ```
Sorry for un-based code, this's handled in r/45813. - Klaus ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43561/#review136543 ----------------------------------------------------------- On March 22, 2016, 9:22 p.m., Klaus Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43561/ > ----------------------------------------------------------- > > (Updated March 22, 2016, 9:22 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Joris Van > Remoortere. > > > Bugs: MESOS-4627 > https://issues.apache.org/jira/browse/MESOS-4627 > > > Repository: mesos > > > Description > ------- > > Improve Ranges parsing to handle single values. > > > Diffs > ----- > > src/common/values.cpp 9f3c0b9930bd3dd9d84d97119419825862f531c3 > src/tests/resources_tests.cpp 6b004d64bb25112b19fc5d98b5bca874c5329e8c > src/tests/values_tests.cpp 929861549e3155c33966896f817f9bf9e6d14354 > > Diff: https://reviews.apache.org/r/43561/diff/ > > > Testing > ------- > > make > make check GTEST_FILTER=~"*" > ./src/mesos-test > > > Thanks, > > Klaus Ma > >
