> On June 8, 2016, 5:32 a.m., Benjamin Mahler wrote: > > src/tests/values_tests.cpp, lines 39-72 > > <https://reviews.apache.org/r/43561/diff/5/?file=1310343#file1310343line39> > > > > It would be great to split apart this test into the respective value > > types, e.g. > > > > ``` > > ValuesTest.ParseScalar > > ValuesTest.ParseRanges > > ValuesTest.ParseSet > > ``` > > > > With more test cases that show what is currently accepted and what is > > not. There are a lot of other formats currently accepted from what I can > > tell (see my comment below).
Logged MESOS-5603 to trace those test refactor; I'll continue to work on this. https://issues.apache.org/jira/browse/MESOS-5603 - Klaus ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43561/#review136543 ----------------------------------------------------------- On June 11, 2016, 10:29 p.m., Klaus Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43561/ > ----------------------------------------------------------- > > (Updated June 11, 2016, 10:29 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Joris Van > Remoortere. > > > Bugs: MESOS-4627 > https://issues.apache.org/jira/browse/MESOS-4627 > > > Repository: mesos > > > Description > ------- > > Improve Ranges parsing to handle single values. > > > Diffs > ----- > > src/common/values.cpp 587cb68551d438621e215953e89818b623b7f71b > src/tests/values_tests.cpp 929861549e3155c33966896f817f9bf9e6d14354 > > Diff: https://reviews.apache.org/r/43561/diff/ > > > Testing > ------- > > make > make check GTEST_FILTER=~"*" > ./src/mesos-test > > > Thanks, > > Klaus Ma > >
