----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49862/#review141841 -----------------------------------------------------------
src/CMakeLists.txt (line 477) <https://reviews.apache.org/r/49862/#comment207239> I'll copy my earlier comment and open up an issue here just to make it clear that I consider it a ship-blocker: > Changing the linking structure of this project has a few very important implications for Windows, and we will need to proceed extremely cautiously. > Before we get into it, could you please explain explain what the immediate reason for the patch is? It would be helpful also to have this justification captured in the commit description, so that it appears in git log. - Alex Clemmer On July 11, 2016, 8:39 p.m., Srinivas Brahmaroutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49862/ > ----------------------------------------------------------- > > (Updated July 11, 2016, 8:39 p.m.) > > > Review request for mesos, Alex Clemmer and Joseph Wu. > > > Bugs: MESOS-5792 > https://issues.apache.org/jira/browse/MESOS-5792 > > > Repository: mesos > > > Description > ------- > > Changed libmesos from static library to a shared library. > > > Diffs > ----- > > 3rdparty/cmake/Mesos3rdpartyConfigure.cmake > eeb27860f6f95d297ccfe273ed76de5355b50ff8 > 3rdparty/http-parser/CMakeLists.txt.template > 7f7105f5d55fd66f3e826c1c37c0074775bf89ea > src/CMakeLists.txt 760519c5568d22f778980b25c3dfedc3c8ef83b1 > src/master/cmake/MasterConfigure.cmake > 6bbd7e87273976f40527d719cc9450ff9a1d2ac7 > src/slave/cmake/SlaveConfigure.cmake > ca4575653e00e8f868160976344ac1d57b5f7d27 > > Diff: https://reviews.apache.org/r/49862/diff/ > > > Testing > ------- > > cmake .. && make > > > Thanks, > > Srinivas Brahmaroutu > >
