> On 七月 26, 2016, 6 a.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 3625 > > <https://reviews.apache.org/r/49616/diff/5/?file=1452185#file1452185line3625> > > > > What about adding some check for the ranges? > > > > An example is here: > > > > https://github.com/apache/mesos/blob/master/src/tests/hierarchical_allocator_tests.cpp#L3657-L3659 > > > > BTW: It is `createRange` and `createPortRanges`
Sorry, I mean `createPorts` and `fragment`. - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49616/#review143484 ----------------------------------------------------------- On 七月 26, 2016, 5:29 a.m., Jacob Janco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49616/ > ----------------------------------------------------------- > > (Updated 七月 26, 2016, 5:29 a.m.) > > > Review request for mesos, James Peach, Joris Van Remoortere, and Jiang Yan Xu. > > > Bugs: MESOS-5781 > https://issues.apache.org/jira/browse/MESOS-5781 > > > Repository: mesos > > > Description > ------- > > - Useful for high framework clusters which carry > many suppressed frameworks that are considered > during allocation. > > > Diffs > ----- > > docs/contributors.yaml b8ecdad2591ba5ee0de50e970b7276587db22270 > src/tests/gc_tests.cpp 11a31dbb8d12bfb8a7f10c8eb87154289ac96f62 > src/tests/hierarchical_allocator_tests.cpp > 0498cd5e54b0e4b87a767585a77699653aa52179 > > Diff: https://reviews.apache.org/r/49616/diff/ > > > Testing > ------- > > MESOS_BENCHMARK=1 GTEST_FILTER="*BENCHMARK_Test.SuppressOffers*" make check > > > Thanks, > > Jacob Janco > >
