> On July 26, 2016, 6 a.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 3637 > > <https://reviews.apache.org/r/49616/diff/5/?file=1452185#file1452185line3637> > > > > Add the elapse time of adding slave here, an example here > > https://github.com/apache/mesos/blob/master/src/tests/hierarchical_allocator_tests.cpp#L3714 > > Jacob Janco wrote: > Collapsed this down to adding slaves rather than tracking for adding > frameworks as in the scenario the frameworks are added without resources > available. Instead why not track frameworks/adding slaves in with a portion > of resources used? What do you think? > > Guangya Liu wrote: > Thanks Jacob, I think that tracking those values separatelly maybe > better. Even though adding framework will have no resources, but this can > calculate the elapse time of adding frameworks and the time of allocator > caused if there are no agents.
Sounds good, adding. - Jacob ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49616/#review143484 ----------------------------------------------------------- On July 26, 2016, 7:28 a.m., Jacob Janco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49616/ > ----------------------------------------------------------- > > (Updated July 26, 2016, 7:28 a.m.) > > > Review request for mesos, James Peach, Joris Van Remoortere, and Jiang Yan Xu. > > > Bugs: MESOS-5781 > https://issues.apache.org/jira/browse/MESOS-5781 > > > Repository: mesos > > > Description > ------- > > - Useful for high framework clusters which carry > many suppressed frameworks that are considered > during allocation. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > bb6947fcecb5b78047e98d10fc1278c612a69548 > > Diff: https://reviews.apache.org/r/49616/diff/ > > > Testing > ------- > > MESOS_BENCHMARK=1 GTEST_FILTER="*BENCHMARK_Test.SuppressOffers*" make check > > > Thanks, > > Jacob Janco > >
