----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50705/ -----------------------------------------------------------
Review request for mesos and Vinod Kone. Bugs: MESOS-4049 https://issues.apache.org/jira/browse/MESOS-4049 Repository: mesos Description ------- The previous behavior was to shutdown partitioned agents that attempt to reregister---unless the master has failed over, in which case the reregistration is allowed (when running in "non-strict" mode). The new behavior is always to allow partitioned agents to reregister. This is part of a longer-term project to allow frameworks to define their own policies for handling tasks running on partitioned agents. In particular, if a framework has the PARTITION_AWARE capability, any tasks running on the partitioned agent will continue to run after reregistration. If the framework is not PARTITION_AWARE, any tasks that were running on such an agent will be killed after the agent reregisters. This is for backward compatibility with the previous behavior. Note that regardless of the PARTITION_AWARE capability, the agent will not be shutdown, which is a change from the previous Mesos behavior. This commit also changes the master so that an agent is removed and then the master receives a message from that agent, the master will no longer attempt to shutdown the agent. This is consistent with the goal of getting the master out of the business of shutting down agents that we suspect are unhealthy. Such an agent will eventually realize it is not registered with the master (e.g., because it won't receive any pings from the master), which will cause it to reregister. Diffs ----- src/master/master.hpp 6decff6f4b9c3434de030fd5c06df4c683a7abad src/master/master.cpp 060dc7f9730808c7fd9b8f9ecdbde0aac14d135c src/tests/master_tests.cpp 6709818d599c068c289bcb714446018577082d8b src/tests/partition_tests.cpp 91969e4c3196a4f36c19abf38e229f3a36e87ea1 Diff: https://reviews.apache.org/r/50705/diff/ Testing ------- make check Thanks, Neil Conway