> On Aug. 23, 2016, 12:56 a.m., Vinod Kone wrote: > > src/tests/partition_tests.cpp, line 169 > > <https://reviews.apache.org/r/50705/diff/4/?file=1472660#file1472660line169> > > > > This test is huge. Can you split PARTITION_AWARE and > > non-PARTITION_AWARE into separate tests? > > Neil Conway wrote: > It's only ~200 lines of code. I think there is some value in keeping the > PARTITION_AWARE and non-PARTITION_AWARE cases in the same test: in most > situations, both cases should behave the same, so we avoid redundancy; it > also makes the situations where different behavior is expected more clear. It > would be easy for the two cases to get out of sync if they are written > separately.
Per discussion, I split this into two separate tests. - Neil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50705/#review146438 ----------------------------------------------------------- On Aug. 25, 2016, 8:23 a.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50705/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2016, 8:23 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-4049 > https://issues.apache.org/jira/browse/MESOS-4049 > > > Repository: mesos > > > Description > ------- > > The previous behavior was to shutdown partitioned agents that attempt to > reregister---unless the master has failed over, in which case the > reregistration is allowed (when running in "non-strict" mode). > > The new behavior is always to allow partitioned agents to reregister. > This is part of a longer-term project to allow frameworks to define > their own policies for handling tasks running on partitioned agents. > > In particular, if a framework has the PARTITION_AWARE capability, any > tasks running on the partitioned agent will continue to run after > reregistration. If the framework is not PARTITION_AWARE, any tasks that > were running on such an agent will be killed after the agent reregisters > (unless the master has failed over). This is for backward compatibility > with the previous ("non-strict") behavior. Note that regardless of the > PARTITION_AWARE capability, the agent will not be shutdown, which is a > change from the previous Mesos behavior. > > This commit also changes the master so that if an agent is removed and > then the master receives a message from that agent, the master will no > longer attempt to shutdown the agent. This is consistent with the goal > of getting the master out of the business of shutting down agents that > we suspect are unhealthy. Such an agent will eventually realize it is > not registered with the master (e.g., because it won't receive any pings > from the master), which will cause it to reregister. > > > Diffs > ----- > > src/master/master.hpp 6decff6f4b9c3434de030fd5c06df4c683a7abad > src/master/master.cpp 789fb9760a5ea60ce3b7b08f17e36cec69349c60 > src/tests/master_tests.cpp 398164d09b8ef14f916122ed8780023c4a3cd0f6 > src/tests/partition_tests.cpp 0a72b345538ca3b9510fccf38ceb68ac71c2b473 > > Diff: https://reviews.apache.org/r/50705/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Neil Conway > >
