----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49817/#review145259 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 164) <https://reviews.apache.org/r/49817/#comment211405> This is not necessary. A failed recovery will cause the agent to exit anyway. src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (lines 185 - 190) <https://reviews.apache.org/r/49817/#comment211406> Hum, I don't like this approach of chaining. Can we just move orphan container logic to `_recover`? ``` return await(recovers) .then(defer(..., &_recover, ...)); ``` src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (lines 195 - 197) <https://reviews.apache.org/r/49817/#comment211408> what you need here is essentially the top level cgroups, right? We should improve cgroups::get to take an additional `recursive` flag. src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 200) <https://reviews.apache.org/r/49817/#comment211409> Ditto. This is not needed. src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 201) <https://reviews.apache.org/r/49817/#comment211410> Please add more context on the failure: ``` Failed to list cgroups under ... ``` src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (lines 234 - 238) <https://reviews.apache.org/r/49817/#comment211412> I'd prefer we log the error if it fails. - Jie Yu On Aug. 9, 2016, 6:38 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49817/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2016, 6:38 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha. > > > Bugs: MESOS-5041 > https://issues.apache.org/jira/browse/MESOS-5041 > > > Repository: mesos > > > Description > ------- > > Implemented `CgroupsIsolatorProcess::recover`. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp > b191b2a52a9645fc902a35ed52909b2142f0b4c0 > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > 2659252d8cffcefc233bc85fb4707c8147272737 > > Diff: https://reviews.apache.org/r/49817/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
