> On Aug. 9, 2016, 9 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 195-197 > > <https://reviews.apache.org/r/49817/diff/19/?file=1469010#file1469010line195> > > > > what you need here is essentially the top level cgroups, right? > > > > We should improve cgroups::get to take an additional `recursive` flag. > > Jie Yu wrote: > Is this addressed? I don't see it being addressed. > > haosdent huang wrote: > Sorry, I misunderstand this before. Suppose the hierarchy is > `/sys/fs/cgroup/memory` and the `flags.cgroups_root` is `mesos`, we only need > the children under `/sys/fs/cgroup/memory/mesos/`, right? Why we need to get > the children recursively here?
Post a follow up patch for this at here https://reviews.apache.org/r/51031/. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49817/#review145259 ----------------------------------------------------------- On Aug. 11, 2016, 2:18 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49817/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2016, 2:18 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha. > > > Bugs: MESOS-5041 > https://issues.apache.org/jira/browse/MESOS-5041 > > > Repository: mesos > > > Description > ------- > > Implemented `CgroupsIsolatorProcess::recover`. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp > b191b2a52a9645fc902a35ed52909b2142f0b4c0 > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > 2659252d8cffcefc233bc85fb4707c8147272737 > > Diff: https://reviews.apache.org/r/49817/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
