> On Sept. 6, 2016, 1:42 p.m., Vinod Kone wrote: > > src/master/master.cpp, line 5168 > > <https://reviews.apache.org/r/50705/diff/8/?file=1490963#file1490963line5168> > > > > s/reregisters/re-registers/ > > > > AFAIK we use a dash for "re-register" whenever it is used in comments > > or log messages. So lets be consistent. > > > > here and everywhere else.
Not opposed to making this consistent, but we use `reregister` in plenty of places right now: ``` $ ag reregister | grep "//" | wc -l 61 ``` Although "re-register" is more common: ``` $ ag "re-register" | grep "//" | wc -l 140 ``` How about we do a global cleanup (I'd actually vote for "reregister", for consistency with identifiers, metrics, etc. named that way)? But as a separate cleanup patch. - Neil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50705/#review147825 ----------------------------------------------------------- On Sept. 5, 2016, 2:38 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50705/ > ----------------------------------------------------------- > > (Updated Sept. 5, 2016, 2:38 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-4049 > https://issues.apache.org/jira/browse/MESOS-4049 > > > Repository: mesos > > > Description > ------- > > The previous behavior was to shutdown partitioned agents that attempt to > reregister---unless the master has failed over, in which case the > reregistration is allowed (when running in "non-strict" mode). > > The new behavior is always to allow partitioned agents to reregister. > This is part of a longer-term project to allow frameworks to define > their own policies for handling tasks running on partitioned agents. > > In particular, if a framework has the PARTITION_AWARE capability, any > tasks running on the partitioned agent will continue to run after > reregistration. If the framework is not PARTITION_AWARE, any tasks that > were running on such an agent will be killed after the agent reregisters > (unless the master has failed over). This is for backward compatibility > with the previous ("non-strict") behavior. Note that regardless of the > PARTITION_AWARE capability, the agent will not be shutdown, which is a > change from the previous Mesos behavior. > > This commit also changes the master so that if an agent is removed and > then the master receives a message from that agent, the master will no > longer attempt to shutdown the agent. This is consistent with the goal > of getting the master out of the business of shutting down agents that > we suspect are unhealthy. Such an agent will eventually realize it is > not registered with the master (e.g., because it won't receive any pings > from the master), which will cause it to reregister. > > > Diffs > ----- > > src/master/master.hpp c32c7e9d859ef73216354e2c03ecc07d0009b12f > src/master/master.cpp b2a19a645528e8fc1fd48f5ac9929d38c9a76b49 > src/tests/master_tests.cpp 6cde15fcd6ca8ec40438c75aed980e83f8de9b86 > src/tests/partition_tests.cpp f3142ad8d50daafcdb70ad9dbb2772f8ba30db00 > > Diff: https://reviews.apache.org/r/50705/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Neil Conway > >
