> On Sept. 8, 2016, 2:28 p.m., Vinod Kone wrote: > > src/slave/slave.cpp, line 2277 > > <https://reviews.apache.org/r/51477/diff/5/?file=1493928#file1493928line2277> > > > > just realized that you need to set proper command info for `DEFAULT` > > executor here? master is not going to fill it! > > > > consequently, you need to ensure that in `doReliableregistration()` > > command info is unset when re-registering `DEFAULT` executor.
Good Catch! I would leave a TODO while committing and would fix it in a follow up JIRA issue/review. - Anand ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51477/#review148184 ----------------------------------------------------------- On Sept. 8, 2016, 5:19 a.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51477/ > ----------------------------------------------------------- > > (Updated Sept. 8, 2016, 5:19 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6076 > https://issues.apache.org/jira/browse/MESOS-6076 > > > Repository: mesos > > > Description > ------- > > This changes implements the `runTaskGroup()` handler on the > agent ensuring that task group is sent atomically to the executor > via the `LAUNCH_GROUP` event. It also refactors `runTask()`/`_runTask()` > to go through a common handler function. Also, it ensures that all > tasks in `framework->pending`/`queuedTasks` that are killed before > running the task group result in all the tasks being killed. > > Review: https://reviews.apache.org/r/51477/ > > > Diffs > ----- > > src/slave/slave.hpp 4add4c0180ea56039e0d5009bad4d9346128bde6 > src/slave/slave.cpp 2da5a2986c427250664b2bf3456039f86e5c6079 > > Diff: https://reviews.apache.org/r/51477/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
