> On Sept. 8, 2016, 9:14 a.m., Vinod Kone wrote: > > src/slave/slave.cpp, line 2112 > > <https://reviews.apache.org/r/51477/diff/3-5/?file=1492261#file1492261line2112> > > > > #2085 explicitly calls stringify(). lets be consistent. > > > > also this could've been better written as > > > > ``` > > vector<vector<TaskID>> taskIds; > > foreach (const TaskGroup& taskGroup, taskGroups) { > > vector<TaskID> taskIds_; > > foreach (const TaskInfo& task, taskGroup.tasks()) { > > taskIds_.push_back(task.task_id()); > > } > > taskIds.push_back(taskIds_); > > } > > > > out << stringify(taskIds); > > ``` > > Vinod Kone wrote: > also realized that master prints task group as a set whereas this code is > printing it as a vector! we need to be consistent.
hmm, we should fix the master to not print the task group as a set (sigh!) The logical equivalent of a `RepeatedPtrField` is either a `vector`/`list`. Using a `set` is counter-intuitive. - Anand ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51477/#review148161 ----------------------------------------------------------- On Sept. 8, 2016, 5:19 a.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51477/ > ----------------------------------------------------------- > > (Updated Sept. 8, 2016, 5:19 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6076 > https://issues.apache.org/jira/browse/MESOS-6076 > > > Repository: mesos > > > Description > ------- > > This changes implements the `runTaskGroup()` handler on the > agent ensuring that task group is sent atomically to the executor > via the `LAUNCH_GROUP` event. It also refactors `runTask()`/`_runTask()` > to go through a common handler function. Also, it ensures that all > tasks in `framework->pending`/`queuedTasks` that are killed before > running the task group result in all the tasks being killed. > > Review: https://reviews.apache.org/r/51477/ > > > Diffs > ----- > > src/slave/slave.hpp 4add4c0180ea56039e0d5009bad4d9346128bde6 > src/slave/slave.cpp 2da5a2986c427250664b2bf3456039f86e5c6079 > > Diff: https://reviews.apache.org/r/51477/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
