> On Oct. 24, 2016, 3:52 a.m., Jiang Yan Xu wrote: > > I ran `sudo make check` and it seems to be fine but it'll be great if you > > can verify it in the "Testing Done" section. The `*Cgroups*` filter may not > > be sufficient as tests that depend on this include those don't have > > `*Cgroups*` in their names. e.g., previously > > `NestedMesosContainerizerTest*` broke the build for the master head when > > this was checked in.
Thank you, let me run a full `sudo make check`. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51031/#review153669 ----------------------------------------------------------- On Oct. 22, 2016, 4:18 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51031/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2016, 4:18 a.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, Zhengju Sha, and > Jiang Yan Xu. > > > Bugs: MESOS-6035 > https://issues.apache.org/jira/browse/MESOS-6035 > > > Repository: mesos > > > Description > ------- > > In some cases, we just want to get the children cgroups instead of > retrieve descendant cgroups recursively. We added an argument to > `cgroups::get` to indicate whether to retrieve cgroups recursively but > made recursive retrieve the default behaviour. This patch fixed some > incorrect `TEST_CGROUPS_ROOT` checks as well. > > > Diffs > ----- > > src/linux/cgroups.hpp cfce09cb57501f2c988a8d997d7c6150280ed53d > src/linux/cgroups.cpp 630e2ec2d0eac2bb35488d0416883df1601224c8 > src/tests/containerizer/cgroups_tests.cpp > 0afaec6ae948cabf1472bf01103210d8f9809cb1 > > Diff: https://reviews.apache.org/r/51031/diff/ > > > Testing > ------- > > ``` > sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*CGROUPS*" --verbose > sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*Cgroups*" --verbose > ``` > > > Thanks, > > haosdent huang > >
