> On Oct. 25, 2016, 7:28 p.m., Jie Yu wrote: > > src/tests/containerizer/cgroups_tests.cpp, lines 135-150 > > <https://reviews.apache.org/r/51031/diff/18/?file=1544155#file1544155line135> > > > > We might need to cleanup this part. It's likely that `baseHierarchy` is > > not the parent of all the subsystems. Imagine a subsystem is not mounted > > initially. And we'll use TEST_CGROUPS_HIERARCHY as the base. However, if > > all other subsystems are mounted under /sys/fs/cgroup, then this test > > fixture will fail. > > > > We can address that in the separate patch, but I'd like to cleanup this > > tech debt.
+1, I copy what we do in `ContainerizerTest<slave::MesosContainerizer>::SetUp()` to here. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51031/#review153817 ----------------------------------------------------------- On Oct. 24, 2016, 2:39 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51031/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2016, 2:39 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, Zhengju Sha, and > Jiang Yan Xu. > > > Bugs: MESOS-6035 > https://issues.apache.org/jira/browse/MESOS-6035 > > > Repository: mesos > > > Description > ------- > > In some cases, we just want to get the children cgroups instead of > retrieve descendant cgroups recursively. We added an argument to > `cgroups::get` to indicate whether to retrieve cgroups recursively but > made recursive retrieve the default behaviour. This patch fixed some > incorrect `TEST_CGROUPS_ROOT` checks as well. > > > Diffs > ----- > > src/linux/cgroups.hpp cfce09cb57501f2c988a8d997d7c6150280ed53d > src/linux/cgroups.cpp 630e2ec2d0eac2bb35488d0416883df1601224c8 > src/tests/containerizer/cgroups_tests.cpp > 0afaec6ae948cabf1472bf01103210d8f9809cb1 > > Diff: https://reviews.apache.org/r/51031/diff/ > > > Testing > ------- > > ``` > sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*" --verbose > ``` > > > Thanks, > > haosdent huang > >