----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56753/#review166801 -----------------------------------------------------------
3rdparty/libprocess/src/jwt_authenticator.cpp (lines 81 - 102) <https://reviews.apache.org/r/56753/#comment238878> I was just discussing this claim with Vinod; let's leave it out of our implementation. We'd like to move toward a world where the new `AuthenticationContext` is first-class throughout the authN/authZ code, so that, for example, a scheduler could subscribe using a credential that resolves to an `AuthenticationContext` which contains claims, but no principal. In such a world, we would simply use the "sub" field as-is within the claims, with no need to translate it into the `principal` member. - Greg Mann On Feb. 22, 2017, 2:28 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56753/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2017, 2:28 p.m.) > > > Review request for mesos and Greg Mann. > > > Bugs: MESOS-7001 > https://issues.apache.org/jira/browse/MESOS-7001 > > > Repository: mesos > > > Description > ------- > > This HTTP authenticator extracts a JWT from the requests' authorization > header using the 'Bearer' schema and validates it against a secret using > HMAC SHA256. The 'sub' claim of the JWT is the extracted principal, all > other claims will be additional labels of the 'AuthenticationContext'. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 75386184108214e67a58c328258ec204099d638c > 3rdparty/libprocess/include/process/authenticator.hpp > e5489c6cb4adc8a822e7dd4515542618c36136f9 > 3rdparty/libprocess/src/authenticator.cpp > cfedb6f7674e0f6690e77a633cdd1bd494c7d2c7 > 3rdparty/libprocess/src/jwt_authenticator.cpp PRE-CREATION > 3rdparty/libprocess/src/tests/http_tests.cpp > fb4da9aecff0370d97a15269c5d8fffb30e0478f > > Diff: https://reviews.apache.org/r/56753/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >