----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56753/#review167221 -----------------------------------------------------------
Note that the upstream `AuthenticationContext` patches have been updated to rename the new type to `Principal`. 3rdparty/libprocess/include/process/authenticator.hpp Lines 186-189 (patched) <https://reviews.apache.org/r/56753/#comment239391> `override` keyword implies `virtual`, so the `virtual` here can be removed 3rdparty/libprocess/src/tests/http_tests.cpp Lines 2002-2003 (patched) <https://reviews.apache.org/r/56753/#comment239380> Fits on one line. 3rdparty/libprocess/src/tests/http_tests.cpp Lines 2011-2013 (patched) <https://reviews.apache.org/r/56753/#comment239381> Fits on one line. 3rdparty/libprocess/src/tests/http_tests.cpp Lines 2025-2027 (patched) <https://reviews.apache.org/r/56753/#comment239382> Fits on one line. 3rdparty/libprocess/src/tests/http_tests.cpp Lines 2038-2039 (patched) <https://reviews.apache.org/r/56753/#comment239385> Why split these across two lines? 3rdparty/libprocess/src/tests/http_tests.cpp Lines 2044-2046 (patched) <https://reviews.apache.org/r/56753/#comment239386> Fits on one line. 3rdparty/libprocess/src/tests/http_tests.cpp Lines 2055-2057 (patched) <https://reviews.apache.org/r/56753/#comment239388> Fits on one line. 3rdparty/libprocess/src/tests/http_tests.cpp Lines 2060-2063 (patched) <https://reviews.apache.org/r/56753/#comment239390> Is this `JWT` used for anything? It might be nice to use this to create the token string rather than relying on a hard-coded string literal? 3rdparty/libprocess/src/tests/http_tests.cpp Lines 2067-2068 (patched) <https://reviews.apache.org/r/56753/#comment239389> Ditto as above - can we consolidate to one line? - Greg Mann On Feb. 28, 2017, 1:36 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56753/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2017, 1:36 p.m.) > > > Review request for mesos, Alexander Rojas and Greg Mann. > > > Bugs: MESOS-7001 > https://issues.apache.org/jira/browse/MESOS-7001 > > > Repository: mesos > > > Description > ------- > > This HTTP authenticator extracts a JWT from the requests' authorization > header using the 'Bearer' schema and validates it against a secret using > HMAC SHA256. The 'sub' claim of the JWT is the extracted principal, all > other claims will be additional labels of the 'AuthenticationContext'. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 75386184108214e67a58c328258ec204099d638c > 3rdparty/libprocess/include/process/authenticator.hpp > e5489c6cb4adc8a822e7dd4515542618c36136f9 > 3rdparty/libprocess/src/authenticator.cpp > cfedb6f7674e0f6690e77a633cdd1bd494c7d2c7 > 3rdparty/libprocess/src/jwt_authenticator.cpp PRE-CREATION > 3rdparty/libprocess/src/tests/http_tests.cpp > fb4da9aecff0370d97a15269c5d8fffb30e0478f > > > Diff: https://reviews.apache.org/r/56753/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
