> On March 1, 2017, 8:41 a.m., Greg Mann wrote: > > 3rdparty/libprocess/src/tests/http_tests.cpp > > Lines 2067-2068 (patched) > > <https://reviews.apache.org/r/56753/diff/3/?file=1651710#file1651710line2067> > > > > Ditto as above - can we consolidate to one line? > > Greg Mann wrote: > Unless it's possible to generate the token using the constructed `JWT`, > per my previous comment?
Yes, that was the intention here, looks like I've forgotten about it. Will fix that. - Jan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56753/#review167221 ----------------------------------------------------------- On Feb. 28, 2017, 2:36 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56753/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2017, 2:36 p.m.) > > > Review request for mesos, Alexander Rojas and Greg Mann. > > > Bugs: MESOS-7001 > https://issues.apache.org/jira/browse/MESOS-7001 > > > Repository: mesos > > > Description > ------- > > This HTTP authenticator extracts a JWT from the requests' authorization > header using the 'Bearer' schema and validates it against a secret using > HMAC SHA256. The 'sub' claim of the JWT is the extracted principal, all > other claims will be additional labels of the 'AuthenticationContext'. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 75386184108214e67a58c328258ec204099d638c > 3rdparty/libprocess/include/process/authenticator.hpp > e5489c6cb4adc8a822e7dd4515542618c36136f9 > 3rdparty/libprocess/src/authenticator.cpp > cfedb6f7674e0f6690e77a633cdd1bd494c7d2c7 > 3rdparty/libprocess/src/jwt_authenticator.cpp PRE-CREATION > 3rdparty/libprocess/src/tests/http_tests.cpp > fb4da9aecff0370d97a15269c5d8fffb30e0478f > > > Diff: https://reviews.apache.org/r/56753/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
