> On March 7, 2017, 8:36 p.m., Greg Mann wrote: > > 3rdparty/libprocess/src/jwt_authenticator.cpp > > Lines 106 (patched) > > <https://reviews.apache.org/r/56753/diff/5/?file=1658278#file1658278line106> > > > > Is the `Option<string>::none()` necessary here? I think the `value` > > member should be default-initialized to `NONE`?
The default constructor of `Principal` is explicitly deleted. > On March 7, 2017, 8:36 p.m., Greg Mann wrote: > > 3rdparty/libprocess/src/tests/http_tests.cpp > > Lines 2070 (patched) > > <https://reviews.apache.org/r/56753/diff/5/?file=1658279#file1658279line2070> > > > > Is the `Option<string>::none()` necessary here? I think the `value` > > member should be default-initialized to `NONE`? See my reply above. - Jan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56753/#review168169 ----------------------------------------------------------- On March 7, 2017, 4:36 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56753/ > ----------------------------------------------------------- > > (Updated March 7, 2017, 4:36 p.m.) > > > Review request for mesos, Alexander Rojas and Greg Mann. > > > Bugs: MESOS-7001 > https://issues.apache.org/jira/browse/MESOS-7001 > > > Repository: mesos > > > Description > ------- > > This HTTP authenticator extracts a JWT from the requests' authorization > header using the 'Bearer' schema and validates it against a secret using > HMAC SHA256. The 'sub' claim of the JWT is the extracted principal, all > other claims will be additional labels of the 'Principal'. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 75386184108214e67a58c328258ec204099d638c > 3rdparty/libprocess/include/process/authenticator.hpp > 00660f42cd4b707d955745bbfea5ffec73f690d6 > 3rdparty/libprocess/src/authenticator.cpp > 3rdparty/libprocess/src/jwt_authenticator.cpp PRE-CREATION > 3rdparty/libprocess/src/tests/http_tests.cpp > a0e23c2300f9f6b9d1143ee1eb115bbf24adf92e > > > Diff: https://reviews.apache.org/r/56753/diff/5/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
