----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58955/#review175220 -----------------------------------------------------------
Looks pretty good. Just some questions about the v0 /logging/toggle endpoint src/master/http.cpp Lines 2056 (patched) <https://reviews.apache.org/r/58955/#comment248656> Should we modify the v0 `/logging/toggle` endpoint to use this authorization::action instead of authorization::GET_ENDPOINT_WITH_PATH ? What's the compatibility/deprecation process there? src/master/http.cpp Lines 2062-2064 (patched) <https://reviews.apache.org/r/58955/#comment248654> I don't care what clang-format says, this is much uglier than my preferred wrapping: ``` [level, duration](const Owned<ObjectApprover>& approver) -> Future<Response> { Try<bool> approved = approver->approved((ObjectApprover::Object())); ``` src/tests/api_tests.cpp Lines 772 (patched) <https://reviews.apache.org/r/58955/#comment248657> Is there a v0 equivalent of this test for `/logging/toggle`? - Adam B On May 12, 2017, 2:28 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58955/ > ----------------------------------------------------------- > > (Updated May 12, 2017, 2:28 a.m.) > > > Review request for mesos, Adam B and Greg Mann. > > > Bugs: MESOS-7414 > https://issues.apache.org/jira/browse/MESOS-7414 > > > Repository: mesos > > > Description > ------- > > Enables authorization in the v1 API call `SET_LOGGING_LEVEL` following > the existing implementation for the agent call with the same name. > Likewise it reuses the authorizer action `SET_LOG_LEVEL`. > > > Diffs > ----- > > src/master/http.cpp e2590a17044ac019b24a24629428d4ec8adc0c31 > src/tests/api_tests.cpp faf3242f9c86d866c4bb5e457fcfe47c1063cc09 > > > Diff: https://reviews.apache.org/r/58955/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
