> On May 17, 2017, 10:51 a.m., Adam B wrote: > > src/master/http.cpp > > Lines 2056 (patched) > > <https://reviews.apache.org/r/58955/diff/3/?file=1716633#file1716633line2056> > > > > Should we modify the v0 `/logging/toggle` endpoint to use this > > authorization::action instead of authorization::GET_ENDPOINT_WITH_PATH ? > > What's the compatibility/deprecation process there?
We discussed that at some point and decided to not modify it, though that could change, but I also wonder how the deprecation/transition here would work > On May 17, 2017, 10:51 a.m., Adam B wrote: > > src/tests/api_tests.cpp > > Lines 772 (patched) > > <https://reviews.apache.org/r/58955/diff/3/?file=1716634#file1716634line772> > > > > Is there a v0 equivalent of this test for `/logging/toggle`? [logging_tests.cpp](https://github.com/apache/mesos/blob/master/src/tests/logging_tests.cpp) - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58955/#review175220 ----------------------------------------------------------- On May 12, 2017, 11:28 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58955/ > ----------------------------------------------------------- > > (Updated May 12, 2017, 11:28 a.m.) > > > Review request for mesos, Adam B and Greg Mann. > > > Bugs: MESOS-7414 > https://issues.apache.org/jira/browse/MESOS-7414 > > > Repository: mesos > > > Description > ------- > > Enables authorization in the v1 API call `SET_LOGGING_LEVEL` following > the existing implementation for the agent call with the same name. > Likewise it reuses the authorizer action `SET_LOG_LEVEL`. > > > Diffs > ----- > > src/master/http.cpp e2590a17044ac019b24a24629428d4ec8adc0c31 > src/tests/api_tests.cpp faf3242f9c86d866c4bb5e457fcfe47c1063cc09 > > > Diff: https://reviews.apache.org/r/58955/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
