> On July 20, 2017, 6:43 p.m., Qian Zhang wrote: > > include/mesos/mesos.proto > > Line 2843 (original), 2922 (patched) > > <https://reviews.apache.org/r/60932/diff/2-3/?file=1780157#file1780157line2922> > > > > Why is `value` an optional field? I think there have to a value for any > > possible semantics, right?
The same, I don't think an `optional` field hurts here and it makes it more flexible. Let's chat tomorrow. - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60932/#review181087 ----------------------------------------------------------- On July 20, 2017, 4:57 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60932/ > ----------------------------------------------------------- > > (Updated July 20, 2017, 4:57 p.m.) > > > Review request for mesos, haosdent huang, Jason Lai, Jie Yu, Qian Zhang, and > Zhitao Li. > > > Bugs: MESOS-6162 > https://issues.apache.org/jira/browse/MESOS-6162 > > > Repository: mesos > > > Description > ------- > > Only statistics information for blkio in protobuf. > > > Diffs > ----- > > include/mesos/mesos.proto 8f8079bd7c2de4e8b2f8f9a56e2731b77b8e1575 > include/mesos/v1/mesos.proto 720f307f8d738b0787e7c47be7ee15be38b2c0d0 > > > Diff: https://reviews.apache.org/r/60932/diff/3/ > > > Testing > ------- > > make > > > Thanks, > > Gilbert Song > >
