----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60933/#review181684 -----------------------------------------------------------
src/linux/cgroups.hpp Lines 458 (patched) <https://reviews.apache.org/r/60933/#comment257312> I'd argue that this is a `Value`, not an entry. I see that the value is obtained from a file (entry) in the cgroup, but the important aspect to capture in the name is that it is a value, not where the value came from. src/linux/cgroups.hpp Lines 468 (patched) <https://reviews.apache.org/r/60933/#comment257314> Since this is only used in the parsing, make this a local static in the cpp file. src/linux/cgroups.hpp Lines 471 (patched) <https://reviews.apache.org/r/60933/#comment257315> Since this is only used in the parser, make this a local status in the cpp file. src/linux/cgroups.cpp Lines 1966 (patched) <https://reviews.apache.org/r/60933/#comment257313> Isn't this the same as: ``` return Entry{None(), None(), value.get()}"; ``` Here and below. - James Peach On July 28, 2017, 12:33 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60933/ > ----------------------------------------------------------- > > (Updated July 28, 2017, 12:33 a.m.) > > > Review request for mesos, haosdent huang, Jason Lai, Jie Yu, James Peach, > Qian Zhang, and Zhitao Li. > > > Bugs: MESOS-6162 > https://issues.apache.org/jira/browse/MESOS-6162 > > > Repository: mesos > > > Description > ------- > > - Data structure for Blkio entities > - Stats helpers for blkio.throttle.io* (generic blkio stats) > - Stats helpers for blkio.io* (CFQ related stats) > - Comments from the kernel blkio doc for helper functions > > > Diffs > ----- > > src/linux/cgroups.hpp eaf0dcad0ed38c507564624f1647e0c731b8b433 > src/linux/cgroups.cpp 334005abfc4ec9b20b7dc0212d852ba1f505dbb5 > > > Diff: https://reviews.apache.org/r/60933/diff/5/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
