----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60933/#review181029 -----------------------------------------------------------
src/linux/cgroups.hpp Lines 582-583 (patched) <https://reviews.apache.org/r/60933/#comment256464> Remove `along with devices and types of operations`? src/linux/cgroups.hpp Lines 586-587 (original), 590-591 (patched) <https://reviews.apache.org/r/60933/#comment256465> Ditto. src/linux/cgroups.cpp Line 1994 (original), 1972 (patched) <https://reviews.apache.org/r/60933/#comment256466> Kill `stat`. src/linux/cgroups.cpp Lines 1986 (patched) <https://reviews.apache.org/r/60933/#comment256475> So this means there can be an entry without operation? But I think the possible semantics are: ``` 8:0 Read 27660288 Total 1000 ``` So it seems not possible to have an entry without operation, instead it can be an entry without device number. src/linux/cgroups.cpp Lines 2005-2009 (patched) <https://reviews.apache.org/r/60933/#comment256467> I think it should be: ``` return (s == "Total" || s == "Read" || s == "Write" || s == "Sync" || s == "Async"); ``` See `mesos::internal::protobuf::isTerminalState()` as an example. - Qian Zhang On July 20, 2017, 8:18 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60933/ > ----------------------------------------------------------- > > (Updated July 20, 2017, 8:18 a.m.) > > > Review request for mesos, haosdent huang, Jason Lai, Jie Yu, Qian Zhang, and > Zhitao Li. > > > Bugs: MESOS-6162 > https://issues.apache.org/jira/browse/MESOS-6162 > > > Repository: mesos > > > Description > ------- > > - Data structure for Blkio entities > - Stats helpers for blkio.throttle.io* (generic blkio stats) > - Stats helpers for blkio.io* (CFQ related stats) > - Comments from the kernel blkio doc for helper functions > > > Diffs > ----- > > src/linux/cgroups.hpp eaf0dcad0ed38c507564624f1647e0c731b8b433 > src/linux/cgroups.cpp 334005abfc4ec9b20b7dc0212d852ba1f505dbb5 > > > Diff: https://reviews.apache.org/r/60933/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
