> On July 20, 2017, 8:39 p.m., Qian Zhang wrote: > > src/linux/cgroups.cpp > > Lines 1986 (patched) > > <https://reviews.apache.org/r/60933/diff/1-2/?file=1778068#file1778068line2008> > > > > So this means there can be an entry without operation? But I think the > > possible semantics are: > > ``` > > 8:0 Read 27660288 > > Total 1000 > > ``` > > So it seems not possible to have an entry without operation, instead it > > can be an entry without device number. > > Gilbert Song wrote: > So basically, for now we have: > ``` > 8:0 Read 27660288 > Total 1000 > 7:0 100 > ``` > > Operations are required for those repeated fields in `blkio` protobuf. > Specifically `sectors` and `time` do not have an operation. Let me add some > comments here.
I see, thanks Gilbert! - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60933/#review181029 ----------------------------------------------------------- On July 21, 2017, 7:58 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60933/ > ----------------------------------------------------------- > > (Updated July 21, 2017, 7:58 a.m.) > > > Review request for mesos, haosdent huang, Jason Lai, Jie Yu, Qian Zhang, and > Zhitao Li. > > > Bugs: MESOS-6162 > https://issues.apache.org/jira/browse/MESOS-6162 > > > Repository: mesos > > > Description > ------- > > - Data structure for Blkio entities > - Stats helpers for blkio.throttle.io* (generic blkio stats) > - Stats helpers for blkio.io* (CFQ related stats) > - Comments from the kernel blkio doc for helper functions > > > Diffs > ----- > > src/linux/cgroups.hpp eaf0dcad0ed38c507564624f1647e0c731b8b433 > src/linux/cgroups.cpp 334005abfc4ec9b20b7dc0212d852ba1f505dbb5 > > > Diff: https://reviews.apache.org/r/60933/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
