----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63253/#review189210 -----------------------------------------------------------
src/tests/default_executor_tests.cpp Lines 1764 (patched) <https://reviews.apache.org/r/63253/#comment266181> +1, I missed this. src/tests/default_executor_tests.cpp Lines 1766-1770 (patched) <https://reviews.apache.org/r/63253/#comment266182> Well, no but nothing will run `alpine` in a Windows container. Looking at `docker_containerizer_tests.cpp`, they're all hard-coded to use `alpine`, so we should drop this change entirely for now. Another team member is working to enable the Docker unit tests on Windows (which will involve swapping from `alpine` to `nanoserver` on Windows). src/tests/default_executor_tests.cpp Line 1766 (original), 1772 (patched) <https://reviews.apache.org/r/63253/#comment266183> Is it just me or did this indentation change? - Andrew Schwartzmeyer On Oct. 24, 2017, 11:04 a.m., Jeff Coffler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63253/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2017, 11:04 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and > Li Li. > > > Bugs: MESOS-6705 > https://issues.apache.org/jira/browse/MESOS-6705 > > > Repository: mesos > > > Description > ------- > > Fixed changes from Gaston (git commit 772c8f5 on 10/02/2017) > for proper operation on Windows. Changed to use new URI methods > introduced as part of MESOS-6705, and used powershell on Windows > to replace "test" command on Linux. > > > Diffs > ----- > > src/tests/default_executor_tests.cpp > 5078bd4d70698f5cbd14c971fcecfd58f8467a04 > > > Diff: https://reviews.apache.org/r/63253/diff/1/ > > > Testing > ------- > > Ran mesos-tests on both Windows and Linux with no errors. > > Specifically ran mesos-tests with > `--gtest_filter=MesosContainerizer/DefaultExecutorTest.*` to verify that the > modified tests ran properly. > > > Thanks, > > Jeff Coffler > >
