> On Oct. 25, 2017, 3:58 p.m., Gaston Kleiman wrote: > > src/tests/default_executor_tests.cpp > > Lines 1764 (patched) > > <https://reviews.apache.org/r/63253/diff/1/?file=1867546#file1867546line1771> > > > > The indentation here looks strange.
This was removed since it's specific to Linux (alpine image). > On Oct. 25, 2017, 3:58 p.m., Gaston Kleiman wrote: > > src/tests/default_executor_tests.cpp > > Lines 1766-1770 (patched) > > <https://reviews.apache.org/r/63253/diff/1/?file=1867546#file1867546line1773> > > > > I don't think this will work inside an `alpine` Docker container, will > > it? Removed since this isn't appropriate for alpine container. I missed that the first time, thanks for pointing it out! - Jeff ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63253/#review189201 ----------------------------------------------------------- On Oct. 24, 2017, 6:04 p.m., Jeff Coffler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63253/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2017, 6:04 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and > Li Li. > > > Bugs: MESOS-6705 > https://issues.apache.org/jira/browse/MESOS-6705 > > > Repository: mesos > > > Description > ------- > > Fixed changes from Gaston (git commit 772c8f5 on 10/02/2017) > for proper operation on Windows. Changed to use new URI methods > introduced as part of MESOS-6705, and used powershell on Windows > to replace "test" command on Linux. > > > Diffs > ----- > > src/tests/default_executor_tests.cpp > 5078bd4d70698f5cbd14c971fcecfd58f8467a04 > > > Diff: https://reviews.apache.org/r/63253/diff/1/ > > > Testing > ------- > > Ran mesos-tests on both Windows and Linux with no errors. > > Specifically ran mesos-tests with > `--gtest_filter=MesosContainerizer/DefaultExecutorTest.*` to verify that the > modified tests ran properly. > > > Thanks, > > Jeff Coffler > >
