----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/#review192185 -----------------------------------------------------------
Ship it! Committing with some small tweaks below and for the commit description. Please resolve all issues from other reviewers with comments. include/mesos/mesos.proto Line 345 (original), 343 (patched) <https://reviews.apache.org/r/61473/#comment270233> Use a `NOTE: `. include/mesos/v1/mesos.proto Line 343 (original), 341 (patched) <https://reviews.apache.org/r/61473/#comment270234> Use a `NOTE: `. src/master/http.cpp Lines 336-338 (patched) <https://reviews.apache.org/r/61473/#comment270235> Put it above `if (!authorizeTask_->accept(*task, framework_->info)) {` line so the order is consistent with the block below. Also add a small comment about this check: ``` // There could be TASK_LOST tasks in this map. See comment for // `unreachableTasks`. ``` src/master/master.cpp Lines 9322-9323 (patched) <https://reviews.apache.org/r/61473/#comment270231> Tweak comment so it's less jagged. src/master/master.cpp Lines 9614-9616 (original), 9565-9568 (patched) <https://reviews.apache.org/r/61473/#comment270232> Reorder the comments and the CHECK. - Jiang Yan Xu On Nov. 28, 2017, 4:59 p.m., Megha Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61473/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2017, 4:59 p.m.) > > > Review request for mesos, James Peach, Vinod Kone, and Jiang Yan Xu. > > > Bugs: MESOS-7215 > https://issues.apache.org/jira/browse/MESOS-7215 > > > Repository: mesos > > > Description > ------- > > Master will not kill the tasks for non-Partition aware frameworks > when an unreachable agent re-registers with the master. > Master used to send a ShutdownFrameworkMessages to the agent > to kill the tasks from non partition aware frameworks including > the ones that are still registered which was problematic because > the offer from this agent could still go to the same framework which > could then launch new tasks. The agent would then receive tasks > of the same framework and ignore them because it thinks the > framework is shutting down. The framework is not shutting down of > course, so from the master and the scheduler's perspective the task > is pending in STAGING forever until the next agent reregistration, > which could happen much later. This commit fixes the problem by > not shutting down the non-partition aware frameworks on such an > agent. > > > Diffs > ----- > > include/mesos/mesos.proto b1ebfe25301549397a48468a02882e971213d45c > include/mesos/v1/mesos.proto d535eb40b205fc176730937eed4ce84ea7a369af > src/master/http.cpp 9dcdcbeeea6135091db5aa21dd54bc14d84f33fc > src/master/master.hpp 1c6a86fb37dee7a2ff4d564f4641a42af6206bb2 > src/master/master.cpp 7bcdb743659435847db6cdea917afc497e641582 > src/tests/partition_tests.cpp 067529acc2b3a1d7f0713c602d5f680ea19b6de8 > > > Diff: https://reviews.apache.org/r/61473/diff/29/ > > > Testing > ------- > > make check > > > Thanks, > > Megha Sharma > >
