----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65127/#review195942 -----------------------------------------------------------
This patch will likely need a few tweaks based on how the previous patch is changed, so I don't have much to say here. src/checks/checker_process.cpp Lines 479-481 (original), 479-487 (patched) <https://reviews.apache.org/r/65127/#comment275372> This is a bit unexpected. Considering that these arguments will be joined a few lines down, how is the quoting maintained? - Joseph Wu On Jan. 16, 2018, 4:09 p.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65127/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2018, 4:09 p.m.) > > > Review request for mesos, Alexander Rukletsov and Andrew Schwartzmeyer. > > > Repository: mesos > > > Description > ------- > > The network health checks called curl and then executed setns to > enter to container network namespace, which did not work on Windows. > To do the equivalent, Windows nows calls docker run with powershell's > curl equivalent (Invoke-WebRequest) and uses the > network=container:<ID> flag to enter the container's namespace. > > > Diffs > ----- > > src/checks/checker_process.hpp 510f3b2e6e689faaf26595214ce377c2b5518f28 > src/checks/checker_process.cpp ddb197b8cc2c503fef5ae20af32f5881fff9833f > > > Diff: https://reviews.apache.org/r/65127/diff/4/ > > > Testing > ------- > > > Thanks, > > Akash Gupta > >
