> On Jan. 16, 2018, 2:47 p.m., Gaston Kleiman wrote: > > src/checks/checker_process.cpp > > Lines 990-1004 (patched) > > <https://reviews.apache.org/r/65127/diff/2/?file=1940536#file1940536line1018> > > > > I just found this blog post: > > https://blogs.technet.microsoft.com/virtualization/2017/12/19/tar-and-curl-come-to-windows/ > > > > It claims that the nanoserver image is only about 200 Mb big and > > includes `curl`. Can't we use that instead of powershell inside a huge > > container? > > Akash Gupta wrote: > Unfortunately, we can't use that specific image, since it's locked to > insider build hosts only. Once the next big Windows update comes out, we can > use that image.
Can you file a JIRA to make this use curl once `microsoft/nanoserver` includes `curl`? Please also add a TODO here linking to the JIRA. - Gaston ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65127/#review195510 ----------------------------------------------------------- On Jan. 16, 2018, 4:09 p.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65127/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2018, 4:09 p.m.) > > > Review request for mesos, Alexander Rukletsov and Andrew Schwartzmeyer. > > > Repository: mesos > > > Description > ------- > > The network health checks called curl and then executed setns to > enter to container network namespace, which did not work on Windows. > To do the equivalent, Windows nows calls docker run with powershell's > curl equivalent (Invoke-WebRequest) and uses the > network=container:<ID> flag to enter the container's namespace. > > > Diffs > ----- > > src/checks/checker_process.hpp 510f3b2e6e689faaf26595214ce377c2b5518f28 > src/checks/checker_process.cpp ddb197b8cc2c503fef5ae20af32f5881fff9833f > > > Diff: https://reviews.apache.org/r/65127/diff/4/ > > > Testing > ------- > > > Thanks, > > Akash Gupta > >
