> On Feb. 20, 2018, 11:43 a.m., Jeff Coffler wrote: > > src/tests/fetcher_tests.cpp > > Lines 132 (patched) > > <https://reviews.apache.org/r/65624/diff/1/?file=1958439#file1958439line132> > > > > These tests pretty much check the fetcher in a "stand-alone" > > environment. Could you add some tests to check within a container as well, > > particularly since fetcher logging is slightly different within a container? > > > > Note that while fetcher output is slightly different within a > > container, fetcher itself isn't (docker is sharing the same directory). But > > we don't have any sort of tests to validate that - that I'm aware of anyway. > > Andrew Schwartzmeyer wrote: > This covers the affected scenarios; nothing changes running "in a > container" on Windows compared to this unit test with respect to output > redirection. When task is started with a URI to fetch, the fetcher is > directly invoked with the sandbox directory as done here to fetch the URI(s), > before the container starts. In essence, the fetcher is always run > "stand-alone". > > Jeff Coffler wrote: > That's correct for fetching. However, logging is somewhat different since > stderr/stdout logging is somewhat different under Docker vs. on a stand-alone > system. That's what I was referring to ...
This fetcher is never used under Docker. What scenario are you imagining? - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65624/#review197799 ----------------------------------------------------------- On Feb. 20, 2018, 11:40 a.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65624/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2018, 11:40 a.m.) > > > Review request for mesos, Akash Gupta, Jeff Coffler, Jie Yu, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > The fetcher is supposed to log its `stderr` output to a redirected file > called `stderr` in the given sandbox directory. There previously existed > a bug on Windows due to incorrect handle inheritance where this > redirection failed silently, leaving the log empty. These unit tests > assert that the correct content is logged to the `stderr` file for both > a success and failure fetch scenario. > > > Diffs > ----- > > src/tests/fetcher_tests.cpp 1b4ba1d286f218731c13180e5189e91f90e3d63f > > > Diff: https://reviews.apache.org/r/65624/diff/1/ > > > Testing > ------- > > Windows (Linux pending): > ``` > [ RUN ] FetcherTest.LogSuccessToStderr > [ OK ] FetcherTest.LogSuccessToStderr (197 ms) > [ RUN ] FetcherTest.LogFailureToStderr > [ OK ] FetcherTest.LogFailureToStderr (320 ms) > ``` > > > Thanks, > > Andrew Schwartzmeyer > >
