----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65759/#review198168 -----------------------------------------------------------
src/docker/executor.cpp Lines 25 (patched) <https://reviews.apache.org/r/65759/#comment278280> Is this necessary? src/docker/executor.cpp Lines 220 (patched) <https://reviews.apache.org/r/65759/#comment278275> s/docker/Docker/ s/retry/retry the/ src/docker/executor.cpp Lines 221 (patched) <https://reviews.apache.org/r/65759/#comment278276> s/inspect_loop/inspectLoop/ src/docker/executor.cpp Lines 233-236 (patched) <https://reviews.apache.org/r/65759/#comment278281> Suggestion: "We need to clean up the hanging Docker CLI process. Discarding the `inspect` future triggers a callback in the Docker library that kills the subprocess and transitions the future." - Greg Mann On Feb. 22, 2018, 8:32 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65759/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2018, 8:32 p.m.) > > > Review request for mesos, Alexander Rukletsov, Gilbert Song, Greg Mann, and > Michael Park. > > > Bugs: MESOS-8574 > https://issues.apache.org/jira/browse/MESOS-8574 > > > Repository: mesos > > > Description > ------- > > This patch adds retries for `inspect` command to workaround docker > daemon hangs. We assume that the docker daemon can be temporarily > unresponsive. If it's unresponsive, then any started docker cli > command hangs. To address the issue, we retry `inspect` in the loop. > > > Diffs > ----- > > src/docker/executor.cpp 80e2d81169f0d4303ca1ddbcef9fa87fe52601fc > > > Diff: https://reviews.apache.org/r/65759/diff/1/ > > > Testing > ------- > > internal CI > > Manually, described in /r/65713 > > > Thanks, > > Andrei Budnik > >
