> On Feb. 23, 2018, 8:57 a.m., Greg Mann wrote: > > src/docker/executor.cpp > > Lines 25 (patched) > > <https://reviews.apache.org/r/65759/diff/1/?file=1963492#file1963492line25> > > > > Is this necessary?
Without this header, I'm getting: ``` ../../src/docker/executor.cpp:230:32: error: ‘await’ was not declared in this scope ``` - Andrei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65759/#review198168 ----------------------------------------------------------- On Feb. 22, 2018, 8:32 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65759/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2018, 8:32 p.m.) > > > Review request for mesos, Alexander Rukletsov, Gilbert Song, Greg Mann, and > Michael Park. > > > Bugs: MESOS-8574 > https://issues.apache.org/jira/browse/MESOS-8574 > > > Repository: mesos > > > Description > ------- > > This patch adds retries for `inspect` command to workaround docker > daemon hangs. We assume that the docker daemon can be temporarily > unresponsive. If it's unresponsive, then any started docker cli > command hangs. To address the issue, we retry `inspect` in the loop. > > > Diffs > ----- > > src/docker/executor.cpp 80e2d81169f0d4303ca1ddbcef9fa87fe52601fc > > > Diff: https://reviews.apache.org/r/65759/diff/2/ > > > Testing > ------- > > internal CI > > Manually, described in /r/65713 > > > Thanks, > > Andrei Budnik > >
