----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65679/#review199267 -----------------------------------------------------------
src/tests/slave_tests.cpp Lines 5179 (patched) <https://reviews.apache.org/r/65679/#comment279562> Could you add a comment here to explain that we run the continuation here to test if all checks in this continuation passes? Ditto for all other `unmocked____run` calls that doesn't generate any task status update or other side effects we check in tests. - Chun-Hung Hsiao On Feb. 16, 2018, 1:22 a.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65679/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2018, 1:22 a.m.) > > > Review request for mesos, Chun-Hung Hsiao and Greg Mann. > > > Bugs: MESOS-8611 > https://issues.apache.org/jira/browse/MESOS-8611 > > > Repository: mesos > > > Description > ------- > > Directly invoking unmock calls in the test process can potentially > cause races with the real mock slave process. It is more robust to > dispatch the unmock calls to the real mock slave process. > > Also added several mock expectations to avoid "uninteresting mock > call" test warnings. > > > Diffs > ----- > > src/tests/slave_tests.cpp e253317a67019302f18afe11e2a314e716cec226 > > > Diff: https://reviews.apache.org/r/65679/diff/4/ > > > Testing > ------- > > `./bin/mesos-tests.sh --gtest_filter=*SlaveTest* --gtest_repeat=-1 > --gtest_break_on_failure` runs forever :) > > > Thanks, > > Meng Zhu > >
