----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65679/ -----------------------------------------------------------
(Updated March 16, 2018, 12:07 p.m.) Review request for mesos, Chun-Hung Hsiao and Greg Mann. Changes ------- Patch updated. Thanks for the informative review. Bugs: MESOS-8611 https://issues.apache.org/jira/browse/MESOS-8611 Repository: mesos Description ------- Directly invoking unmock calls in the test process can potentially cause races with the real mock slave process. It is more robust to dispatch the unmock calls to the real mock slave process. Also added several mock expectations to avoid "uninteresting mock call" test warnings. Diffs (updated) ----- src/tests/slave_tests.cpp f76500ebdb67f131a57a3b5aaae8c952d019e354 Diff: https://reviews.apache.org/r/65679/diff/5/ Changes: https://reviews.apache.org/r/65679/diff/4-5/ Testing ------- `./bin/mesos-tests.sh --gtest_filter=*SlaveTest* --gtest_repeat=-1 --gtest_break_on_failure` runs forever :) Thanks, Meng Zhu