----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67722/#review205373 -----------------------------------------------------------
A regression test would be nice, I guess that would involve mocking an authenticator? src/master/master.cpp Lines 9669-9670 (patched) <https://reviews.apache.org/r/67722/#comment288271> I think the previous wording was clearer. If there is an error, the new error message implies that authorization failed, but what actually failed was the authentication. Nit: `Unauthorized` starts with upper case, but `discarded` with lower case, if we decide to keep the new wording, I'd try to be consistent. - Gastón Kleiman On June 25, 2018, 10:56 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67722/ > ----------------------------------------------------------- > > (Updated June 25, 2018, 10:56 a.m.) > > > Review request for mesos, Gastón Kleiman, Greg Mann, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > This patch fixes a bug where the code path could cause a crash because > of calling `Fture<T>::get()` on a future which is failed. > > > Diffs > ----- > > src/master/master.cpp 4ade16f044f8a4fdafd5afaba4e6a23232f83a5a > > > Diff: https://reviews.apache.org/r/67722/diff/1/ > > > Testing > ------- > > ```sh > make check > ``` > > > Thanks, > > Alexander Rojas > >
