----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67722/#review205374 -----------------------------------------------------------
src/master/master.cpp Lines 9667-9672 (patched) <https://reviews.apache.org/r/67722/#comment288272> Perhaps we could provide more precise logging here? If the future is failed, I might expect to see a log like: "An error was encountered while attempting authentication of <PID>: <error message from authenticator>" If the Option is NONE, I might expect something like: "Authentication of <PID> was unsuccessful: invalid credentials" WDYT? - Greg Mann On June 25, 2018, 5:56 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67722/ > ----------------------------------------------------------- > > (Updated June 25, 2018, 5:56 p.m.) > > > Review request for mesos, Gastón Kleiman, Greg Mann, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > This patch fixes a bug where the code path could cause a crash because > of calling `Fture<T>::get()` on a future which is failed. > > > Diffs > ----- > > src/master/master.cpp 4ade16f044f8a4fdafd5afaba4e6a23232f83a5a > > > Diff: https://reviews.apache.org/r/67722/diff/1/ > > > Testing > ------- > > ```sh > make check > ``` > > > Thanks, > > Alexander Rojas > >
