----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67187/#review206467 -----------------------------------------------------------
src/tests/master_tests.cpp Lines 9175-9181 (patched) <https://reviews.apache.org/r/67187/#comment289438> How can we prevent a possible race here? - Greg Mann On July 18, 2018, 1:46 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67187/ > ----------------------------------------------------------- > > (Updated July 18, 2018, 1:46 a.m.) > > > Review request for mesos, Gastón Kleiman and Gilbert Song. > > > Bugs: MESOS-8847 > https://issues.apache.org/jira/browse/MESOS-8847 > > > Repository: mesos > > > Description > ------- > > This patch adds `MasterTest.TaskStateMetrics`, which verifies that > per-framework task state metrics for both terminal and active task > states report correct values, even after agent reregistration. > > > Diffs > ----- > > src/tests/master_tests.cpp 8e04023ed04e79881e0d323c2e2283bebaf262eb > > > Diff: https://reviews.apache.org/r/67187/diff/4/ > > > Testing > ------- > > The new test was run ~10,000 times with no failures. > > > Thanks, > > Greg Mann > >
