----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67187/#review206468 -----------------------------------------------------------
src/tests/master_tests.cpp Lines 9185 (patched) <https://reviews.apache.org/r/67187/#comment289440> I think we should verify the metrics at this point too. - Gastón Kleiman On July 17, 2018, 6:46 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67187/ > ----------------------------------------------------------- > > (Updated July 17, 2018, 6:46 p.m.) > > > Review request for mesos, Gastón Kleiman and Gilbert Song. > > > Bugs: MESOS-8847 > https://issues.apache.org/jira/browse/MESOS-8847 > > > Repository: mesos > > > Description > ------- > > This patch adds `MasterTest.TaskStateMetrics`, which verifies that > per-framework task state metrics for both terminal and active task > states report correct values, even after agent reregistration. > > > Diffs > ----- > > src/tests/master_tests.cpp 8e04023ed04e79881e0d323c2e2283bebaf262eb > > > Diff: https://reviews.apache.org/r/67187/diff/4/ > > > Testing > ------- > > The new test was run ~10,000 times with no failures. > > > Thanks, > > Greg Mann > >