----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68732/ -----------------------------------------------------------
(Updated Sept. 21, 2018, 11:24 p.m.) Review request for mesos, Gastón Kleiman and Meng Zhu. Changes ------- Updated per feedback. Repository: mesos Description ------- This avoids making excessive map lookups each time we calculate the share for a node in the tree. Now, when the weight is needed, the value is cached. If the weight gets updated, we update the cached value. This approach proved cleaner than trying to ensure freshly constructed nodes have the right weight. Diffs (updated) ----- src/master/allocator/sorter/drf/sorter.hpp 71352c848e812b7c499dfbf0f09dc86fac3ee8e1 src/master/allocator/sorter/drf/sorter.cpp a45f66ff0d77becb6f96f7ff4c288e4ab218e070 src/master/allocator/sorter/random/sorter.hpp 6bfeda0f0d02b4738a6d46a7798b1bf4751f0b38 src/master/allocator/sorter/random/sorter.cpp fc47756927a6e45183713955e819e0640318f838 Diff: https://reviews.apache.org/r/68732/diff/2/ Changes: https://reviews.apache.org/r/68732/diff/1-2/ Testing ------- make check Thanks, Benjamin Mahler
