----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68732/ -----------------------------------------------------------
(Updated Sept. 25, 2018, 12:22 a.m.) Review request for mesos, Gastón Kleiman and Meng Zhu. Changes ------- Updated to handle the virtual leaf case. Repository: mesos Description ------- This avoids making excessive map lookups each time we calculate the share for a node in the tree. Now, when the weight is needed, the value is cached. If the weight gets updated, we update the cached value. This approach proved cleaner than trying to ensure freshly constructed nodes have the right weight. Diffs (updated) ----- src/master/allocator/sorter/drf/sorter.hpp 2957a2ea4e6d8fe9cc661be1a42ab3e17a338769 src/master/allocator/sorter/drf/sorter.cpp a45f66ff0d77becb6f96f7ff4c288e4ab218e070 src/master/allocator/sorter/random/sorter.hpp 825c158322885d52803994c0a827a67aedd609f4 src/master/allocator/sorter/random/sorter.cpp fc47756927a6e45183713955e819e0640318f838 Diff: https://reviews.apache.org/r/68732/diff/3/ Changes: https://reviews.apache.org/r/68732/diff/2-3/ Testing ------- make check Thanks, Benjamin Mahler
