----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68732/#review208981 -----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs. Reviews applied: `['68732']` Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2393/mesos-review-68732 Relevant logs: - [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2393/mesos-review-68732/logs/mesos-tests.log): ``` I0925 02:37:11.954577 824 executor.cpp:909] Sending SIGTERM to process tree at pid 13ate of task adaa82b3-ef7a-451c-82d6-6195d12081d9 of framework 9035e180-fc49-4faa-8613-6561c1f64586-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED) I0925 02:37:11.951586 12948 slave.cpp:6640] Shutting down executor 'adaa82b3-ef7a-451c-82d6-6195d12081d9' of framework 9035e180-fc49-4faa-8613-6561c1f64586-0000 at executor(1)@192.10.1.5:50600 I0925 02:37:11.953577 12948 slave.cpp:909] Agent terminating W0925 02:37:11.953577 12948 slave.cpp:3917] Ignoring shutdown framework 9035e180-fc49-4faa-8613-6561c1f64586-0000 because it is terminating I0925 02:37:11.953577 11348 master.cpp:11030] Removing task adaa82b3-ef7a-451c-82d6-6195d12081d9 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 9035e180-fc49-4faa-8613-6561c1f64586-0000 on agent 9035e180-fc49-4faa-8613-6561c1f64586-S0 at slave(463)@192.10.1.5:65174 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net) I0925 02:37:11.956585 11348 master.cpp:1251] Agent 9035e180-fc49-4faa-8613-6561c1f64586-S0 at slave(463)@192.10.1.5:65174 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net) disconnected I0925 02:37:11.957578 11348 master.cpp:3267] Disconnecting agent 9035e180-fc49-4faa-8613-6561c1f64586-S0 at slave(463)@192.10.1.5:65174 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net) I0925 02:37:11.957578 11348 master.cpp:3286] Deactivating agent 9035e180-fc49-4faa-8613-6561c1f64586-S0 at slave(463)@192.10.1.5:65174 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net) I0925 02:37:11.958577 9012 hierarchical.cpp:359] Removed framework 9035e180-fc49-4faa-8613-6561c1f64586-0000 I0925 02:37:11.958577 14172 containerizer.cpp:2455] Destroying container 80c946a2-997b-4ff5-8de3-c96577b2ea54 in RUNNING state I0925 02:37:11.958577 14172 containerizer.cpp:3118] Transitioning the state of container 80c946a2-997b-4ff5-8de3-c96577b2ea54 from RUNNING to DESTROYING I0925 02:37:11.958577 9012 hierarchical.cpp:795] Agent 9035e180-fc49-4faa-8613-[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (689 ms) [----------] 1 test from IsolationFlag/MemoryIsolatorTest (713 ms total) [----------] Global test environment tear-down [==========] 1052 tests from 103 test cases ran. (501831 ms total) [ PASSED ] 1051 tests. [ FAILED ] 1 test, listed below: [ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName 1 FAILED TEST YOU HAVE 231 DISABLED TESTS 6561c1f64586-S0 deactivated I0925 02:37:11.959573 14172 launcher.cpp:166] Asked to destroy container 80c946a2-997b-4ff5-8de3-c96577b2ea54 I0925 02:37:11.987630 5136 containerizer.cpp:2957] Container 80c946a2-997b-4ff5-8de3-c96577b2ea54 has exited I0925 02:37:12.024587 13200 master.cpp:1093] Master terminating I0925 02:37:12.026571 420 hierarchical.cpp:637] Removed agent 9035e180-fc49-4faa-8613-6561c1f64586-S0 I0925 02:37:12.335326 11836 process.cpp:926] Stopped the socket accept loop ``` - Mesos Reviewbot Windows On Sept. 25, 2018, 12:22 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68732/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2018, 12:22 a.m.) > > > Review request for mesos, Gastón Kleiman and Meng Zhu. > > > Repository: mesos > > > Description > ------- > > This avoids making excessive map lookups each time we calculate the > share for a node in the tree. Now, when the weight is needed, the > value is cached. If the weight gets updated, we update the cached > value. This approach proved cleaner than trying to ensure freshly > constructed nodes have the right weight. > > > Diffs > ----- > > src/master/allocator/sorter/drf/sorter.hpp > 2957a2ea4e6d8fe9cc661be1a42ab3e17a338769 > src/master/allocator/sorter/drf/sorter.cpp > a45f66ff0d77becb6f96f7ff4c288e4ab218e070 > src/master/allocator/sorter/random/sorter.hpp > 825c158322885d52803994c0a827a67aedd609f4 > src/master/allocator/sorter/random/sorter.cpp > fc47756927a6e45183713955e819e0640318f838 > > > Diff: https://reviews.apache.org/r/68732/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > >