----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70200/#review213751 -----------------------------------------------------------
Thanks for the update! This is looking pretty good. We also have to update the docs, are you going to do that here or do you plan to add another patch to the chain? include/mesos/v1/scheduler/scheduler.proto Line 218 (original), 221 (patched) <https://reviews.apache.org/r/70200/#comment299744> Shouldn't we mark this as deprecated by adding: `[deprecated=true]`? I don't think it has any effect on the generated code, but it would be useful for anyone reading the proto. include/mesos/v1/scheduler/scheduler.proto Line 226 (original), 229 (patched) <https://reviews.apache.org/r/70200/#comment299746> We should mark this field as deprecated. include/mesos/v1/scheduler/scheduler.proto Lines 534-536 (patched) <https://reviews.apache.org/r/70200/#comment299745> The `call()` method hasn't changed, so I don't think this statement is accurate. The field will be set to something if an API call returns a response, but it just happens to be the case that no call does that at the moment. I would delete this comment. - Gastón Kleiman On March 14, 2019, 10:24 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70200/ > ----------------------------------------------------------- > > (Updated March 14, 2019, 10:24 a.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, Chun-Hung Hsiao, > Gastón Kleiman, James DeFelice, Megha Sharma, and Jiang Yan Xu. > > > Bugs: MESOS-9648 > https://issues.apache.org/jira/browse/MESOS-9648 > > > Repository: mesos > > > Description > ------- > > This patch updates the v1 scheduler API's RECONCILE_OPERATIONS > call to provide a 202 Accepted response with an empty body, > rather than a response containing all reconciliation results. > In this new scheme, reconciliation requests are satisfied with > operation status updates on the scheduler's event stream. > Related tests are also updated. > > NOTE that this is a breaking change for schedulers consuming > the experimental operation reconciliation API. > > > Diffs > ----- > > include/mesos/scheduler/scheduler.proto > 5443048a620395c6beb0d93a325187df905b1b0b > include/mesos/v1/scheduler/scheduler.proto > 3cfe0251847431da09a4eb9c81aecb77c84100dc > src/master/http.cpp d6d47405f871f88235cc203ef5cf9f1460754e0c > src/master/master.hpp 953cc5b8ab6a8e1920a3ad63fb2dd6382e3603ec > src/master/master.cpp dc68fc324de7242737123015fbac19a2129778ce > src/tests/operation_reconciliation_tests.cpp > 6a815ad694e2a608ce324715c920833f825793a0 > src/tests/storage_local_resource_provider_tests.cpp > 7945384867f26fa15dc734a235ae509d5d6d350f > > > Diff: https://reviews.apache.org/r/70200/diff/3/ > > > Testing > ------- > > `make check` > > > Thanks, > > Greg Mann > >
