----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70200/#review213851 -----------------------------------------------------------
Fix it, then Ship it! Minor question, but other LGTM. include/mesos/scheduler/scheduler.proto Lines 220-228 (original), 223-231 (patched) <https://reviews.apache.org/r/70200/#comment299949> Is there some reason why the un-versioned protobufs do not have the same deprecation tags? - Joseph Wu On March 15, 2019, 3:35 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70200/ > ----------------------------------------------------------- > > (Updated March 15, 2019, 3:35 p.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, Chun-Hung Hsiao, > Gastón Kleiman, James DeFelice, Megha Sharma, and Jiang Yan Xu. > > > Bugs: MESOS-9648 > https://issues.apache.org/jira/browse/MESOS-9648 > > > Repository: mesos > > > Description > ------- > > This patch updates the v1 scheduler API's RECONCILE_OPERATIONS > call to provide a 202 Accepted response with an empty body, > rather than a response containing all reconciliation results. > In this new scheme, reconciliation requests are satisfied with > operation status updates on the scheduler's event stream. > Related tests are also updated. > > NOTE that this is a breaking change for schedulers consuming > the experimental operation reconciliation API. > > > Diffs > ----- > > include/mesos/scheduler/scheduler.proto > 5443048a620395c6beb0d93a325187df905b1b0b > include/mesos/v1/scheduler/scheduler.proto > 3cfe0251847431da09a4eb9c81aecb77c84100dc > src/master/http.cpp d6d47405f871f88235cc203ef5cf9f1460754e0c > src/master/master.hpp 953cc5b8ab6a8e1920a3ad63fb2dd6382e3603ec > src/master/master.cpp dc68fc324de7242737123015fbac19a2129778ce > src/tests/operation_reconciliation_tests.cpp > 6a815ad694e2a608ce324715c920833f825793a0 > src/tests/storage_local_resource_provider_tests.cpp > 7945384867f26fa15dc734a235ae509d5d6d350f > > > Diff: https://reviews.apache.org/r/70200/diff/4/ > > > Testing > ------- > > `make check` > > > Thanks, > > Greg Mann > >