> On March 20, 2019, 3:13 p.m., Benjamin Bannier wrote: > > src/csi/v0_volume_manager_process.hpp > > Lines 176 (patched) > > <https://reviews.apache.org/r/70216/diff/2/?file=2132476#file2132476line176> > > > > Can or should this be `const`?
Although this can, it has a side effect that's not directly related to the data members. Given this, and given that it's an actor in a non-copyable object, I'd prefer not adding the `const` qualifier to give an illusion that it's side-effect free. WDYT? - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70216/#review213840 ----------------------------------------------------------- On March 15, 2019, 5:17 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70216/ > ----------------------------------------------------------- > > (Updated March 15, 2019, 5:17 a.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. > > > Bugs: MESOS-9622 > https://issues.apache.org/jira/browse/MESOS-9622 > > > Repository: mesos > > > Description > ------- > > The recovery logic is similar to SLRP's `recoverVolumes` method. But > `VolumeManager` no longer recovers all volumes to their steady states > since this is not necessary. Together with the new `publishVolume` > design, the recovery logic is now simpler. > > > Diffs > ----- > > src/csi/v0_volume_manager.cpp PRE-CREATION > src/csi/v0_volume_manager_process.hpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/70216/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Chun-Hung Hsiao > >
