----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70216/ -----------------------------------------------------------
(Updated March 28, 2019, 7:55 a.m.) Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. Changes ------- Addressed Benjamin's comments. Bugs: MESOS-9622 https://issues.apache.org/jira/browse/MESOS-9622 Repository: mesos Description ------- In addition to perform volume state recovery, the `recoverVolumes` function also recovers service manager and preparing services now. The whole logic will be moved out from SLRP to v0 `VolumeManager` later. During volume state recovery, we no longer recover all volumes to steady states, since transient states are properly handled in SLRP. To simplify the recovery logic, a `publishVolume` method that conforms to the volume manager's `publishVolume` is introduced. Diffs (updated) ----- src/resource_provider/storage/provider.cpp 2711503cdb58cb9b34af8c9fad0908c5f788a2af src/resource_provider/storage/provider_process.hpp a5536b3d735e01eb1c4dc52d0602d973155f3c93 Diff: https://reviews.apache.org/r/70216/diff/6/ Changes: https://reviews.apache.org/r/70216/diff/5-6/ Testing ------- make check Thanks, Chun-Hung Hsiao